jiafu1115 commented on code in PR #22349:
URL: https://github.com/apache/kafka/pull/22349#discussion_r3288945683
##########
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##########
@@ -776,30 +776,30 @@ class DynamicBrokerConfigTest {
verifyIncorrectRemoteCopyLagProps(
retentionMs = 1000L,
logLocalRetentionMs = -2L,
- remoteCopyLagMs = 1001L,
+ logRemoteCopyLagMs = 1001L,
retentionBytes = 1000L,
logLocalRetentionBytes = -2L,
- remoteCopyLagBytes = 100L
+ logRemoteCopyLagBytes = 100L
)
// remote copy lag bytes cannot exceed effective local retention bytes
verifyIncorrectRemoteCopyLagProps(
retentionMs = 1000L,
logLocalRetentionMs = -2L,
- remoteCopyLagMs = 100L,
+ logRemoteCopyLagMs = 100L,
retentionBytes = 1000L,
Review Comment:
retentionMs = 1000L,
logLocalRetentionMs = -2L,
logRemoteCopyLagMs = 100L,
retentionBytes = 1000L,
logLocalRetentionBytes = -2L,
logRemoteCopyLagBytes = 1001L
@muralibasani thanks for your comments. here should be right.
they are two groups. each have 3 configure name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
