muralibasani commented on code in PR #22346:
URL: https://github.com/apache/kafka/pull/22346#discussion_r3289093633
##########
server/src/main/java/org/apache/kafka/server/InterBrokerNetworkClientFactory.java:
##########
@@ -30,13 +30,16 @@
import org.apache.kafka.common.security.JaasContext;
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.common.utils.internals.LogContext;
+import org.apache.kafka.server.config.AbstractKafkaConfig;
import java.util.Map;
-public class NetworkUtils {
+public class InterBrokerNetworkClientFactory {
- public static NetworkClient buildNetworkClient(String prefix,
- KafkaConfig config,
+ private InterBrokerNetworkClientFactory() {}
+
+ public static NetworkClient create(String prefix,
+ AbstractKafkaConfig config,
Review Comment:
I think the params are not indented here well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
