JiayaoS commented on code in PR #22347:
URL: https://github.com/apache/kafka/pull/22347#discussion_r3291393051
##########
storage/src/test/java/org/apache/kafka/tiered/storage/integration/TransactionsTestHelper.java:
##########
@@ -923,7 +923,9 @@ public static void testFailureToFenceEpoch(
long producerId;
int initialProducerEpoch;
- try (var producer1 = createTransactionalProducer(clusterInstance,
"transactional-producer")) {
Review Comment:
> How about producer1.close(duration 5 secs) in finally ? This will force a
hard close after the time out, instead of waiting for pending reqs.
Thanks, that’s a fair point. I considered `close(Duration.ofSeconds(5))` as
well, but it changes the cleanup behavior to force-close after the timeout. The
current approach keeps the try-with-resources close graceful, while bounding
the pending requests with a shorter request timeout. Maybe we should decide
which behavior is more appropriate for this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
