chia7712 commented on code in PR #22352:
URL: https://github.com/apache/kafka/pull/22352#discussion_r3292137139
##########
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##########
@@ -247,8 +247,8 @@ class DynamicBrokerConfigTest {
val err2 = assertThrows(classOf[ConfigException], () =>
config.dynamicConfig.validate(props2, perBrokerConfig = false))
assertTrue(err2.getMessage.contains("value should be at least half the
current value"))
- val props3 = new Properties()
- props3.put(RemoteLogManagerConfig.REMOTE_LOG_READER_THREADS_PROP, "-1")
+ val props = new Properties()
+ props.put(RemoteLogManagerConfig.REMOTE_LOG_READER_THREADS_PROP, "-1")
Review Comment:
For consistency, we should use the name prop3, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
