jiafu1115 commented on code in PR #20913:
URL: https://github.com/apache/kafka/pull/20913#discussion_r3294761216
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -608,6 +631,32 @@ private static void
validateRemoteStorageRetentionTime(Map<String, ?> props) {
}
}
+ private static void validateRemoteCopyLagTime(Map<?, ?> props) {
+ Long retentionMs = (Long) props.get(TopicConfig.RETENTION_MS_CONFIG);
+ Long localRetentionMs = (Long)
props.get(TopicConfig.LOCAL_LOG_RETENTION_MS_CONFIG);
+ Long remoteCopyLagMs = (Long)
props.get(TopicConfig.REMOTE_COPY_LAG_MS_CONFIG);
+ long effectiveLocalRetentionMs = localRetentionMs == -2 ? retentionMs
: localRetentionMs;
+ if (remoteCopyLagMs > 0 && effectiveLocalRetentionMs >= 0
+ && remoteCopyLagMs > effectiveLocalRetentionMs) {
+ String message = String.format("Value must not exceed %s
(effective value: %d)",
+ TopicConfig.LOCAL_LOG_RETENTION_MS_CONFIG,
effectiveLocalRetentionMs);
+ throw new ConfigException(TopicConfig.REMOTE_COPY_LAG_MS_CONFIG,
remoteCopyLagMs, message);
+ }
+ }
+
+ private static void validateRemoteCopyLagSize(Map<?, ?> props) {
Review Comment:
@chia7712 thanks for review. Fix it on #22363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
