chia7712 commented on code in PR #22034:
URL: https://github.com/apache/kafka/pull/22034#discussion_r3297073671
##########
tests/docker/run_tests.sh:
##########
@@ -40,13 +39,6 @@ else
export KAFKA_MODE="jvm"
fi
-if [ "$REBUILD" == "t" ]; then
- ./gradlew clean systemTestLibs
- if [ "$KAFKA_MODE" == "native" ]; then
- ./gradlew clean releaseTarGz
- fi
-fi
-
Review Comment:
Do we really need to leave the codebase in a temporary, mismatched state if
we already agree on the long-term direction? I think we can address both
KAFKA-20379 and KAFKA-20531 together right now in this PR to keep things clean.
1. Move the logic for both `systemTestLibs` and `releaseTarGz` into
`ducker-ak`
2. `run_tests.sh` should simply convert the legacy `REBUILD=t` into the
`--clean-build` flag when calling ducker-ak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
