UladzislauBlok commented on code in PR #22366:
URL: https://github.com/apache/kafka/pull/22366#discussion_r3299223641
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MemoryLRUCache.java:
##########
@@ -232,4 +242,14 @@ public void close() {
public int size() {
return this.map.size();
}
+
+ // visible for testing
+ boolean isRestoring() {
+ return restoring;
+ }
+
+ // visible for testing
+ RecordBatchingStateRestoreCallback restoreCallback() {
+ return restoreCallback;
+ }
Review Comment:
imo this is anti pattern, and we shouldn't test so low level functions.
"Test behavior, not implementation"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
