smjn commented on code in PR #22368:
URL: https://github.com/apache/kafka/pull/22368#discussion_r3306447733
##########
core/src/main/java/kafka/server/share/ShareCoordinatorMetadataCacheHelperImpl.java:
##########
@@ -93,8 +95,8 @@ public boolean isDlqEnabledOnTopic(String topic) {
return false;
}
Object isEnabled =
props.get(TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_CONFIG);
- if (isEnabled instanceof Boolean) {
- return (boolean) isEnabled;
+ if (isEnabled instanceof String) {
Review Comment:
Ok, will encapsulate in LogConfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
