chia7712 commented on code in PR #22060:
URL: https://github.com/apache/kafka/pull/22060#discussion_r3315811713
##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredJws.java:
##########
@@ -301,7 +300,7 @@ public static Map<String, Object> toMap(String split)
throws OAuthBearerIllegalT
for (Entry<String, JsonNode> entry : jsonNode.properties()) {
retval.put(entry.getKey(), convert(entry.getValue()));
}
- return Collections.unmodifiableMap(retval);
+ return Map.copyOf(retval);
Review Comment:
I meant we don’t need to do any change to it. The immutable wrapper is good
enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
