nicktelford commented on code in PR #22311:
URL: https://github.com/apache/kafka/pull/22311#discussion_r3316470456
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStoreTest.java:
##########
@@ -189,4 +194,20 @@ public void shouldCloseUnderlyingStore() {
verify(inner).close();
}
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void shouldDelegateReadOnlyUncommittedToInner() {
+ final ReadOnlySessionStore<Bytes, byte[]> view =
mock(ReadOnlySessionStore.class);
Review Comment:
The existing tests already set-up mocks with `@Mock`, which I think is
preferable to adding `beforeEach`. Updated all 4 tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
