nicktelford commented on code in PR #22313:
URL: https://github.com/apache/kafka/pull/22313#discussion_r3319542966
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingSessionStore.java:
##########
@@ -249,6 +333,14 @@ public KeyValueIterator<Windowed<Bytes>, byte[]>
backwardFindSessions(final Byte
final Bytes keyTo,
final long earliestSessionEndTime,
final long latestSessionStartTime) {
+ return backwardFindSessionsInternal(keyFrom, keyTo,
earliestSessionEndTime, latestSessionStartTime, wrapped());
+ }
+
+ private KeyValueIterator<Windowed<Bytes>, byte[]>
backwardFindSessionsInternal(final Bytes keyFrom,
+
final Bytes keyTo,
Review Comment:
Not sure what you're getting at here: they're all correctly aligned as far
as I can see?
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingSessionStore.java:
##########
@@ -220,6 +297,14 @@ public KeyValueIterator<Windowed<Bytes>, byte[]>
findSessions(final Bytes keyFro
final Bytes
keyTo,
final long
earliestSessionEndTime,
final long
latestSessionStartTime) {
+ return findSessionsInternal(keyFrom, keyTo, earliestSessionEndTime,
latestSessionStartTime, wrapped());
+ }
+
+ private KeyValueIterator<Windowed<Bytes>, byte[]>
findSessionsInternal(final Bytes keyFrom,
+
final Bytes keyTo,
Review Comment:
Same, these all look aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
