chia7712 commented on code in PR #22409:
URL: https://github.com/apache/kafka/pull/22409#discussion_r3324587925
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java:
##########
@@ -95,7 +95,7 @@
* tombstone deletion.</li>
* </ol>
*/
-public class LogCleaner implements BrokerReconfigurable {
+public class LogCleaner implements BrokerReconfigurable<AbstractConfig> {
Review Comment:
From another perspective, we could move `BrokerReconfigurable` back to the
server module, and then create server-only dynamic adapters for those classes
located in non-server modules. The advantage is that `BrokerReconfigurable`
could use `AbstractKafkaConfig` directly, which is simple and straightforward.
The downside is that we need to create those adapters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
