smjn opened a new pull request, #22436: URL: https://github.com/apache/kafka/pull/22436
* Currently, the code in SharePartition only looks at the broker feature config `share.version=2` to enable DLQ flow. However, this in not correct. * Per KIP-1191 > A share group can be configured with the name of a topic to be used as the group's DLQ topic. For a share group with a DLQ topic, when a record's delivery is rejected by the consumer ... * This implies that gating along with DLQ topic being configured on the share group is ESSENTIAL for DLQ flows to start. * In light of this - appropriate changes have been made in SharePartition where the configProvider is leveraged to fetch the DLQ topic config applied to the share group. In case the topic name is empty, DLQ flow does not execute. * Tests have been added to reflect the same and existing tests updated with mock DLQ manager to assert on the enqueue calls. Co-authored-by: Claude [email protected] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
