jiafu1115 commented on code in PR #22394:
URL: https://github.com/apache/kafka/pull/22394#discussion_r3332815676
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -102,20 +102,22 @@ public class TopicConfig {
"(i.e. retention.ms/bytes).";
public static final String REMOTE_COPY_LAG_MS_CONFIG =
"remote.copy.lag.ms";
- public static final String REMOTE_COPY_LAG_MS_DOC = "Controls how long to
delay uploading segments to remote storage. " +
- "When set to 0, immediate upload without any delay check. " +
- "When set to a positive value (ms), a segment can't become
eligible for upload until the time since the latest record in the segment
reaches the value. " +
- "The value should not exceed the real local retention ms except
the latter is retained indefinitely (-1). " +
- "When set to -1, resolves to the real local retention ms as
maximum delay. " +
- "For how the real local retention time is computed, see
<code>local.retention.ms</code>.";
+ public static final String REMOTE_COPY_LAG_MS_DOC = "Controls one of the
two upload eligibility checks (time and size) for copying segments to remote
storage. " +
Review Comment:
@kamalcph Thanks for provide the impovement. here. Controls one of the
two-> Why we don't say: Controls the time eligibility check directly?
same with another one.
there are two same statements:
"Controls one of the two upload eligibility checks (time and size) for
copying segments to remote storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
