nicktelford commented on PR #22318: URL: https://github.com/apache/kafka/pull/22318#issuecomment-4595563552
> Thanks @nicktelford LGTM - one minor comment seems the tests only use `READ_UNCOMMITTED` is this intentional? If not maybe we can do a follow-up PR to add `READ_COMMITTED` as well. @bbejeck The `ReadOnlyView` itself is isolation-level-agnostic — it wraps whatever `ReadOnlyXxxStore<Bytes, byte[]>` the inner store returns from `readOnly(isolationLevel)`, and the inner store is the one that interprets the level. Since the `ReadOnlyView` doesn't branch on isolation level, testing its behaviour with `READ_UNCOMMITTED` covers all paths; the `READ_COMMITTED` test only needs to confirm the delegation, which it does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
