nicktelford commented on PR #22314: URL: https://github.com/apache/kafka/pull/22314#issuecomment-4602880927
> Thanks for the PR @nicktelford overall looks good. I have a question about the moving the `synchronized` method modfier. > > Also the `org.apache.kafka.streams.state.internals.CachingPersistentWindowStoreTest#shouldNotThrowInvalidBackwardRangeExceptionWithNegativeFromKey` is failing @bbejeck Fixed the synchronisation, as requested, and rebased on trunk, which should fix the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
