josefk31 commented on code in PR #22191:
URL: https://github.com/apache/kafka/pull/22191#discussion_r3343466968
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -2128,6 +2132,19 @@ public CompletableFuture<Void> registerController(
EnumSet.noneOf(ControllerOperationFlag.class));
}
+ @Override
+ public CompletableFuture<Void> unregisterController(
+ ControllerRequestContext context,
+ int controllerId
+ ) {
+ if (nodeId == controllerId && isActiveController()) {
Review Comment:
Thanks @kevin-wu24 as discussed, to address "Inactive case (1) + become
active before time Y" we need to move this check into the
`ControllerWriteEvent`.
Just to confirm, we want the following behaviours for this error:
|inactive X|inactive Y|response|
|-|-|-|
|N|N|Not a controller|
|N|Y|Configuration error|
|Y|N|Not a controller|
|Y|Y|Configuration error|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
