frankvicky commented on code in PR #22464:
URL: https://github.com/apache/kafka/pull/22464#discussion_r3349976068
##########
group-coordinator/src/main/resources/common/message/StreamsGroupMetadataValue.json:
##########
@@ -27,7 +27,11 @@
{ "name": "ValidatedTopologyEpoch", "versions": "0+", "taggedVersions":
"0+", "tag": 0, "default": -1, "type": "int32",
"about": "The topology epoch whose topics are validated to be present in
a valid configuration in the metadata." },
{ "name": "LastAssignmentConfigs","taggedVersions": "0+",
"nullableVersions": "0+","tag": 1, "default": null,
- "type": "[]LastAssignmentConfig", "about": "The last used configuration
parameters as key-value pairs." }
+ "type": "[]LastAssignmentConfig", "about": "The last used configuration
parameters as key-value pairs." },
+ { "name": "StoredTopologyEpoch", "versions": "0+", "taggedVersions": "0+",
"tag": 2, "default": -1, "type": "int32",
+ "about": "The topology epoch whose description is currently stored in
the topology description plugin, or -1 if none is stored." },
+ { "name": "LastFailedTopologyEpoch", "versions": "0+", "taggedVersions":
"0+", "tag": 3, "default": -1, "type": "int32",
+ "about": "The topology epoch whose description push the plugin
permanently rejected (signalled by
StreamsTopologyDescriptionPermanentFailureException), or -1 if none.
Heartbeat-path solicitation is suppressed while this equals the current
topology epoch, to avoid hot-looping." }
Review Comment:
Used tags 2 and 3 (not 3 and 4) — Kafka's message generator enforces
contiguous tag IDs, and tag 2 was unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
