lucasbru commented on code in PR #21799:
URL: https://github.com/apache/kafka/pull/21799#discussion_r3354829304
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8961,8 +8974,11 @@ private Map<String, String>
streamsGroupAssignmentConfigs(String groupId) {
Optional<GroupConfig> groupConfig =
groupConfigManager.groupConfig(groupId);
final Integer numStandbyReplicas =
groupConfig.flatMap(GroupConfig::streamsNumStandbyReplicas)
.orElse(config.streamsGroupNumStandbyReplicas());
+ final Long acceptableRecoveryLag =
groupConfig.flatMap(GroupConfig::streamsAcceptableRecoveryLag)
+ .orElse(config.streamsGroupAcceptableRecoveryLag());
return new TreeMap<>(Map.of(
- "num.standby.replicas", numStandbyReplicas.toString()
+ "num.standby.replicas", numStandbyReplicas.toString(),
+ "acceptable.recovery.lag", acceptableRecoveryLag.toString()
Review Comment:
It's as you say. If you need it in the assignor, you put it here, otherwise
you don't. It depends on how you want plan to implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
