smjn commented on code in PR #22412:
URL: https://github.com/apache/kafka/pull/22412#discussion_r3355736238
##########
server/src/main/java/org/apache/kafka/server/share/dlq/ShareGroupDLQStateManager.java:
##########
@@ -154,6 +172,16 @@ CompletableFuture<Void> dlq(ShareGroupDLQRecordParameter
param, long requestBack
return future;
}
+ // Visibility for tests
+ void setGenerateCallback(Runnable generateCallback) {
+ this.generateCallback = generateCallback;
+ }
Review Comment:
No, this is a dynamic - we want to see if 2 handlers have been enqueued
inside the `nodeRPCMap`. Just spying on `addRequestToNodeMap` is not sufficient.
However, I will replace this with a executer based poll approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
