[ 
https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18086182#comment-18086182
 ] 

Muralidhar Basani commented on KAFKA-13152:
-------------------------------------------

Hi all, as discussed in thread 
https://lists.apache.org/thread/nb92mk029z4k3dm4tj0zoors6qbd8yg8, raised a PR 
for this.

https://github.com/apache/kafka/pull/22458

- Most of the changes are picked up from #20292, + addressing pending comments, 
closing some gaps, a fix for counter inflation on corrupted records and trunk 
rebase
- new config input.buffer.max.bytes and deprecating 
buffered.records.per.partition
- updated docs

[~mjsax] [~frankvicky]  request your review. 

> Replace "buffered.records.per.partition" & "cache.max.bytes.buffering" with 
> "{statestore.cache}/{input.buffer}.max.bytes"
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-13152
>                 URL: https://issues.apache.org/jira/browse/KAFKA-13152
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Muralidhar Basani
>            Priority: Major
>              Labels: kip
>
> The current config "buffered.records.per.partition" controls how many records 
> in maximum to bookkeep, and hence it is exceed we would pause fetching from 
> this partition. However this config has two issues:
> * It's a per-partition config, so the total memory consumed is dependent on 
> the dynamic number of partitions assigned.
> * Record size could vary from case to case.
> And hence it's hard to bound the memory usage for this buffering. We should 
> consider deprecating that config with a global, e.g. "input.buffer.max.bytes" 
> which controls how much bytes in total is allowed to be buffered. This is 
> doable since we buffer the raw records in <byte[], byte[]>.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to