lucliu1108 commented on code in PR #22489:
URL: https://github.com/apache/kafka/pull/22489#discussion_r3364932010
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -151,7 +155,13 @@ public class TopicConfig {
public static final String MAX_COMPACTION_LAG_MS_CONFIG =
"max.compaction.lag.ms";
public static final String MAX_COMPACTION_LAG_MS_DOC = "The maximum time a
message will remain " +
- "ineligible for compaction in the log. Only applicable for logs that
are being compacted.";
+ "ineligible for compaction in the log. Only applicable for logs that
are being compacted. " +
+ "Because the active segment is never compacted, for compacted topics
this value also drives " +
+ "active segment rolling: the effective time-based roll deadline is the
smaller of segment.ms " +
Review Comment:
> the effective time-based roll deadline is
"threshold" might be more suitable than "deadline" here
Also, could you set each config name wrapped in tags, like
`<code>segment.ms</code>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
