eduwercamacaro commented on PR #22491: URL: https://github.com/apache/kafka/pull/22491#issuecomment-4635608291
Thanks for the PR @nicktelford It seems to me that every time a segment is expired, we immediately remove it from the `segments` collection. So, in that case, the `committedOffset(partition)` method won't iterate over expired segments. So, I'm not fully sure that this solves the issue. Separately, We are currently storing offsets on every active segment during commit, but new segments never inherit the existing offsets data, which gives us a small window of time where the `commitedOffset` returns `null` for a partition that is not yet persisted into a new segment. It will only be consistent on the next commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
