oneby-wang opened a new pull request, #22494: URL: https://github.com/apache/kafka/pull/22494
The metadata shell currently exposes `--snapshot` for selecting the metadata file to read, but the files users should pass to this tool use the `.checkpoint` suffix. This adds `--checkpoint` as the preferred option while keeping `--snapshot` and `-s` as deprecated aliases for compatibility. The command-line parsing is now factored into package-private helpers so that the CLI behavior can be tested without invoking `main`, `Exit.exit`, or loading a real checkpoint. The new tests cover parsing the new option, preserving shell commands, accepting the deprecated aliases with a warning, rejecting simultaneous new and old options, and failing when no checkpoint option is provided. The KRaft operations documentation now shows `--checkpoint` in the metadata shell example. Testing: - `./gradlew :shell:test --tests org.apache.kafka.shell.MetadataShellTest` - `./gradlew :shell:test --tests org.apache.kafka.shell.MetadataShellIntegrationTest` - `./gradlew :shell:check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
