lianetm commented on code in PR #22461:
URL: https://github.com/apache/kafka/pull/22461#discussion_r3380988334
##########
tests/kafkatest/services/verifiable_consumer.py:
##########
@@ -439,6 +442,9 @@ def start_cmd(self, node):
if self.max_messages > 0:
cmd += " --max-messages %s" % str(self.max_messages)
+ if self.close_timeout_sec >= 0:
Review Comment:
running a test to validate I got failures on all combinations for older
versions, and a pass on dev only. Makes sense really because the old ones do
not support this close option. Should we gate the version here? (>= 4.4.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
