brandboat commented on code in PR #22474:
URL: https://github.com/apache/kafka/pull/22474#discussion_r3381097834


##########
server/src/main/java/org/apache/kafka/server/DefaultAutoTopicCreationManager.java:
##########
@@ -276,12 +275,12 @@ yield new CreatableTopic()
         };
     }
 
-    private static CreatableTopicConfigCollection 
convertToTopicConfigCollections(Properties config) {
+    private static CreatableTopicConfigCollection 
convertToTopicConfigCollections(Map<String, String> config) {
         return new CreatableTopicConfigCollection(
                 config.entrySet().stream()
                         .map(entry -> new CreatableTopicConfig()
-                                .setName(entry.getKey().toString())
-                                .setValue(entry.getValue().toString()))
+                                .setName(entry.getKey())
+                                .setValue(entry.getValue()))
                         .toList()
                         .iterator()

Review Comment:
   Thanks for the review!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to