squah-confluent commented on PR #22485: URL: https://github.com/apache/kafka/pull/22485#issuecomment-4670363653
https://github.com/apache/kafka/compare/0d036c87a5895d2833e49c7b3ccba77511fc4f6f..65b29a766b1fc55bbd54b1f815d9c2ea9d9ede3d#diff-3348a3606859398432ede2a538363e9135c6b796f968ff7a1ecffa31293d5300 Added note to javadoc ```diff + * <p>Null values are not supported. ``` Added null check ```diff public V put(K key, V value) { + Objects.requireNonNull(value); ``` https://github.com/apache/kafka/compare/0d036c87a5895d2833e49c7b3ccba77511fc4f6f..65b29a766b1fc55bbd54b1f815d9c2ea9d9ede3d#diff-272971e71983532a976ca13273331162b16622ad1227db72468f8114240cd97b Removed unused method ```diff - private static OverlayMap<String, String> populated() { - ... - } ``` Renamed method ```diff - public void testIsEmptyWhenAllBaseRemoved() { + public void testIsEmptyWhenAllBaseEntriesRemoved() { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
