brandboat commented on code in PR #22522:
URL: https://github.com/apache/kafka/pull/22522#discussion_r3388682767
##########
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##########
@@ -2074,6 +2074,7 @@ public void testSendTxnOffsetsWithGroupIdTransactionV2() {
}
@Test
+ @SuppressWarnings("removal")
Review Comment:
Sadly, `ConsumerGroupMetadata` is still a concrete class and not an
interface. [The API change won't happen until
5.0](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=340037295#KIP1136:MakeConsumerGroupMetadataaninterface-Compatibility,Deprecation,andMigrationPlan).
I would lean toward adding a suppression here for now and cleaning it up in
5.0. At that point, we'll be able to create a proper ConsumerGroupMetadata
instance instead of relying on the current workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
