smjn commented on code in PR #22479:
URL: https://github.com/apache/kafka/pull/22479#discussion_r3397475127
##########
server/src/main/java/org/apache/kafka/server/share/dlq/ShareGroupDLQStateManager.java:
##########
@@ -214,6 +231,7 @@ class ProduceRequestHandler implements
RequestCompletionHandler {
private Node dlqPartitionLeaderNode;
private int dlqDestinationPartition;
private ShareGroupDLQMetadataCacheHelper.TopicPartitionData
dlqTopicPartitionData;
+ private Map<Long, Record> originalRecordData;
Review Comment:
@apoorvmittal10
No, `originalDataRecords` was always a member variable of the handler class
- not the top level ShareGroupDLQStateManager. New handler class object is
created for each new DLQ request from the SharePartition. `originalDataRecords`
is NOT shared between multiple DLQ requests.
Approach is same - its just that it is initialized lazily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
