zoro30102000 commented on PR #22548: URL: https://github.com/apache/kafka/pull/22548#issuecomment-4688497225
One point for reviewers: the IOException handling on the delete follows the resume() precedent and logs the error without failing the task, so a failed delete leaves behavior exactly as today for that session. The stricter alternative would be to fail the task, or to throw TaskCorruptedException so the wipe happens immediately through the existing machinery. I kept the precedent shape, happy to change it if you prefer fail closed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
