chia7712 commented on code in PR #22454:
URL: https://github.com/apache/kafka/pull/22454#discussion_r3403087006
##########
core/src/main/scala/kafka/server/KafkaBroker.scala:
##########
@@ -120,5 +120,10 @@ trait KafkaBroker extends Logging {
if (linuxIoMetricsCollector.usable()) {
metricsGroup.newGauge("linux-disk-read-bytes", () =>
linuxIoMetricsCollector.readBytes())
Review Comment:
Could `linuxIoMetricsCollector` have a method to update them all at once
instead of one by one? Otherwise, it will take the lock and access the
underlying files frequently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
