chia7712 commented on code in PR #22564:
URL: https://github.com/apache/kafka/pull/22564#discussion_r3409777544
##########
core/src/testFixtures/scala/kafka/api/AbstractSaslTest.scala:
##########
@@ -17,6 +17,5 @@ package kafka.api
* Separate class required to overcome issues related to usage of scala trait
in java code.
* @see SaslClientsWithInvalidCredentialsTest
*/
-abstract class AbstractSaslTest extends IntegrationTestHarness with SaslSetup {
+abstract class AbstractSaslTest extends IntegrationTestHarness with
SaslSetupFixtures {
Review Comment:
"This base class is exposed to both the core and tool modules. Another
better way is to rewrite `SaslClientsWithInvalidCredentialsTest` using
`ClusterInstance`. Would you mind opening a minor patch to rewrite
`SaslClientsWithInvalidCredentialsTest` first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
