smjn commented on PR #22572: URL: https://github.com/apache/kafka/pull/22572#issuecomment-4702973821
@Shekharrajak Thanks for the PR and improvements. The code does not handle duplicate batches correctly. For example: ## Same state ``` (0, 5,state0,count1), (0,5,state0,count1), (11,15,state0,count1) ``` is producing ``` (0,15,state0,count1) ``` which means its inventing (6,10,state0,count1) ## Different states ``` (0, 5,state2,count1), (0,5,state2,count1), (11,15,state0,count1) ``` is producing ``` (0,15,state2,count1) // BIGGER CONCERN AS STATE CHANGING OF OLDER BATCHES ``` which means its inventing (6,10,state2,count1) and modifying older batch state. Since there is no restriction on the the batches coming from SharePartition and to the coordinator - duplicates need to be handled possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
