Shekharrajak commented on code in PR #22581:
URL: https://github.com/apache/kafka/pull/22581#discussion_r3414787923
##########
share-coordinator/src/test/java/org/apache/kafka/coordinator/share/ShareCoordinatorShardTest.java:
##########
@@ -1006,6 +1006,8 @@ public void testReadStateLeaderEpochUpdateNoUpdate() {
CoordinatorResult<ReadShareGroupStateResponseData, CoordinatorRecord>
result2 = shard.readStateAndMaybeUpdateLeaderEpoch(request2);
assertTrue(result2.records().isEmpty()); // Leader epoch -1 - no
update.
+ assertEquals(Errors.NONE.code(),
result2.response().results().get(0).partitions().get(0).errorCode());
Review Comment:
to assert the response succeeds with Errors.NONE
Previously a fenced response also produced no records, so the test could
pass while masking the bug. The test now verifies leaderEpoch = -1 returns
success, generates no update record, and keeps the stored leader epoch
unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
