Russole commented on code in PR #22579:
URL: https://github.com/apache/kafka/pull/22579#discussion_r3414996849
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##########
@@ -660,7 +658,7 @@ public static <K, V> List<ConsumerRecord<K, V>>
waitUntilMinRecordsReceived(fina
final List<ConsumerRecord<K, V>> readData =
readRecords(topic, consumer, waitTime, expectedNumRecords);
accumData.addAll(readData);
- assertThat(reason, accumData.size(),
is(greaterThanOrEqualTo(expectedNumRecords)));
+ assertTrue(accumData.size() >= expectedNumRecords, reason);
Review Comment:
Thanks @chia7712 for the review. I can remove the `IntegrationTestUtils`
changes.
One thing I noticed locally is that if I revert those changes but still
remove `Hamcrest` from `tools`, `:tools:test` fails with `NoClassDefFoundError:
org/hamcrest/Matchers`.
So even though `tools` does not use `Hamcrest` directly, some `tools` tests
call `IntegrationTestUtils` from the Streams integration tests, and that class
still uses `Hamcrest`. That means `tools` still needs `Hamcrest` indirectly
unless we also remove the `Hamcrest` usage there.
For example, these tests fail after reverting the `IntegrationTestUtils`
change:
-
`ResetIntegrationWithSslTest.testReprocessingFromScratchAfterResetWithIntermediateInternalTopic`
-
`ResetIntegrationWithSslTest.testReprocessingFromScratchAfterResetWithIntermediateUserTopic`
-
`ResetIntegrationWithSslTest.testReprocessingFromScratchAfterResetWithoutIntermediateUserTopic`
- `ResetIntegrationWithSslTest.testResetWhenInternalTopicsAreSpecified`
Do you prefer that I keep the `IntegrationTestUtils` change in this PR, or
should I leave the `tools` `Hamcrest` dependency as-is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
