lianetm commented on code in PR #21592:
URL: https://github.com/apache/kafka/pull/21592#discussion_r3415584311
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClient.java:
##########
@@ -161,9 +161,20 @@ public boolean hasReadyNodes(long now) {
* @return true if update succeeded, false otherwise.
*/
public boolean awaitMetadataUpdate(Timer timer) {
+ return awaitMetadataUpdate(timer, false);
+ }
+
+ /**
+ * Block waiting on the metadata refresh with a timeout.
+ *
+ * @param timer Timer bounding how long this method can block
+ * @param disableWakeup true if we should not check for wakeups, false
otherwise
+ * @return true if update succeeded, false otherwise.
+ */
+ public boolean awaitMetadataUpdate(Timer timer, boolean disableWakeup) {
Review Comment:
could we add the "throws WakeUp" java doc?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClient.java:
##########
@@ -161,9 +161,20 @@ public boolean hasReadyNodes(long now) {
* @return true if update succeeded, false otherwise.
*/
public boolean awaitMetadataUpdate(Timer timer) {
Review Comment:
here too, probably worth clarifying that this one "throws WakeUp"
(consistent with the java doc of the poll in this same file btw)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
