frankvicky commented on code in PR #22552:
URL: https://github.com/apache/kafka/pull/22552#discussion_r3421397316
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4466,7 +4472,13 @@ private CoordinatorResult<StreamsGroupHeartbeatResult,
CoordinatorRecord> stream
if (instanceId == null) {
StreamsGroupMember member = group.getMemberOrThrow(memberId);
log.info("[GroupId {}][MemberId {}] Member {} left the streams
group.", groupId, memberId, memberId);
- return streamsGroupFenceMember(group, member, new
StreamsGroupHeartbeatResult(response, Map.of(), group.currentTopologyEpoch()));
+ return streamsGroupFenceMember(group, member, new
StreamsGroupHeartbeatResult(
+ response,
+ Map.of(),
+ group.currentTopologyEpoch(),
Review Comment:
I added a `StreamsGroupHeartbeatResult.withoutEpochContext(data)` static
factory that defaults the three epoch fields to `-1`, and pulled the
leave/fence sites onto it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
