[
https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18089515#comment-18089515
]
Preethi KCS commented on KAFKA-14922:
-------------------------------------
Hi [~mjsax] , [~alisa23] , I wanted to clarify the design direction for the
{{--force}} flag behavior in the Streams Reset Tool.
As discussed in this PR , {{--force}} is currently used for force-removing
active consumer group members (KAFKA-9146). In the same change, it is also
being used to bypass the application-id existence validation check.
[https://github.com/apache/kafka/pull/21826]
This introduces two unrelated behaviors under a single flag, which may be
confusing for users:
* forcing active group member removal
* skipping application-id existence validation
I wanted to check whether the intended design is:
# Continue reusing {{--force}} for both behaviors, or
# Introduce a separate flag for skipping application-id validation (e.g.
{{--skip-application-id-validation}} or similar)
As noted in this ticket, this seems to have been left open for resolution at
the KIP/design level, so I’d like to align before finalizing the implementation.
I’ve also requested access to Confluence so I can start drafting a KIP to
discuss there.
> kafka-streams-application-reset deletes topics not belonging to specified
> application-id
> ----------------------------------------------------------------------------------------
>
> Key: KAFKA-14922
> URL: https://issues.apache.org/jira/browse/KAFKA-14922
> Project: Kafka
> Issue Type: Bug
> Components: streams, tools
> Affects Versions: 3.4.0
> Reporter: Jørgen
> Assignee: Preethi KCS
> Priority: Major
> Labels: beginner, needs-kip, newbie
>
> Slack-thread:
> [https://confluentcommunity.slack.com/archives/C48AHTCUQ/p1681908267206849]
> When running the command _kafka-streams-application-reset --bootstrap-servers
> $BOOTSTRAP --application-id foo_ all internal topics that _starts with_ foo
> is deleted. This happens even if there's no application-id named foo.
> Example:
> {code:java}
> Application IDs:
> foo-v1
> foo-v2
> Internal topics:
> foo-v1-repartition-topic-repartition
> foo-v2-repartition-topic-repartition
> Application reset:
> kafka-streams-application-reset --bootstrap-servers $BOOTSTRAP
> --application-id foo
> > No input or intermediate topics specified. Skipping seek.
> Deleting inferred internal topics [foo-v2-repartition-topic-repartition,
> foo-v1-repartition-topic-repartition]
> Done.{code}
> Expected behaviour is that the command fails as there are no application-id's
> with the name foo instead of deleting all foo* topics.
> This is critical on typos or if application-ids starts with the same name as
> others (for example if we had foo-v21 and wanted to reset foo-v2)
> The bug should be located here:
> [https://github.com/apache/kafka/blob/c14f56b48461f01743146d58987bc8661ba0d459/tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java#L693]
> Should check that the topics matches the application-id exactly instead of
> checking that it starts with the application-id.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
