Shekharrajak commented on code in PR #22603:
URL: https://github.com/apache/kafka/pull/22603#discussion_r3428079184
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##########
@@ -1182,4 +1200,8 @@ private boolean isShareGroupsEnabled(MetadataImage image)
{
boolean shouldRunPeriodicJob() {
return shouldRunPeriodicJob;
}
+
+ private boolean shouldRunPeriodicJob(long generation) {
+ return shouldRunPeriodicJob && periodicJobGeneration.get() ==
generation;
Review Comment:
It must not start work if it belongs to old generation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
