chickenchickenlove commented on code in PR #22559:
URL: https://github.com/apache/kafka/pull/22559#discussion_r3436172544
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManagerTest.java:
##########
@@ -1493,6 +1495,30 @@ public void testPollOnCloseWhenIsLeaving() {
assertEquals(LEAVE_GROUP_MEMBER_EPOCH,
streamsRequest.data().memberEpoch());
}
+ @ParameterizedTest
+ @EnumSource(value = CloseOptions.GroupMembershipOperation.class, names =
{"DEFAULT", "REMAIN_IN_GROUP"})
+ public void testPollOnCloseWhenStaticMemberIsLeaving(final
CloseOptions.GroupMembershipOperation operation) {
Review Comment:
I was planning to cover this with a Ducktape test.
I'll take a look at the existing integration tests and check whether this
can be covered by adding a new test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
