jsancio commented on code in PR #22505:
URL: https://github.com/apache/kafka/pull/22505#discussion_r3437701581
##########
raft/src/testFixtures/java/org/apache/kafka/raft/RaftClientTestContext.java:
##########
@@ -968,14 +968,14 @@ void deliverRequest(ApiMessage request, short version) {
versionedRequest,
time.milliseconds()
);
- inboundRequest.completion.whenComplete((response, exception) -> {
+ client.handle(inboundRequest).whenComplete((response, exception) -> {
if (exception != null) {
+ // TODO: this doesn't do anything interesting. Figure out a
way to fail the test
Review Comment:
Yes. Good catch. I forgot to implement this. The solution is a little
verbose since I have to move the exception to the polling/test thread and
outside the completion stage.
I'll create a follow up PR to make KafkaRaftClientTestContext's client field
private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
