Shekharrajak commented on code in PR #22357:
URL: https://github.com/apache/kafka/pull/22357#discussion_r3438377658
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java:
##########
@@ -398,9 +398,6 @@ private byte finalDeliveryState(PersisterStateBatch batch,
TransactionResult res
return DELIVERY_STATE_AVAILABLE;
}
if (batch.stagedDeliveryState() !=
PersisterStateBatch.NO_STAGED_DELIVERY_STATE) {
- if (batch.stagedDeliveryState() == DELIVERY_STATE_ARCHIVING) {
Review Comment:
For transactional REJECT with DLQ enabled, the coordinator must preserve
staged ARCHIVING on commit.
The source **SharePartition owns DLQ phase 2**; after reload it resumes
ARCHIVING, writes
the DLQ record, and then archives the share-state batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
