jsancio commented on code in PR #22111:
URL: https://github.com/apache/kafka/pull/22111#discussion_r3422624928
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientFetchTest.java:
##########
@@ -789,52 +788,99 @@ void
testObserverFetchesBetweenLeaderAndBootstrapServers() throws Exception {
local.directoryId().get()
)
.withStaticVoters(voters)
-
.withBootstrapServers(Optional.of(List.of(RaftClientTestContext.mockAddress(otherVoter.id()))))
+ .withBootstrapServers(
+
Optional.of(List.of(RaftClientTestContext.mockAddress(bootstrapVoter.id())))
Review Comment:
Let's document that you are doing this to reliably check fetches to the
leader (known node) vs fetches to the bootstrap server (unknown nodes). Another
way to check this is that "bootstrap nodes" have an unknown id. We represent
this in the network client by giving those nodes an id less than -1. RPCs to
known kafka nodes have an id greater than or equal to 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
