suzhiking commented on code in PR #22586: URL: https://github.com/apache/kafka/pull/22586#discussion_r3493907060
########## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ########## Review Comment: I went with a separate `enforceConfig` helper because the two configs don't fit that model cleanly. `checkIfUnexpectedUserSpecifiedClientConfig` is driven by static `_OVERRIDES` maps + `NON_CONFIGURABLE_` arrays, but `group.id` is filled in at runtime, so there's no constant to put in the static `Map.of(...)`. Also, `group.id` and `partition.assignment.strategy` are main-consumer-only and `CONSUMER_DEFAULT_OVERRIDES` is used in `getCommonConsumerConfigs`, adding these to the map would leak `partition.assignment.strategy` to restore/global consumers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
