sebastienviale commented on code in PR #22725:
URL: https://github.com/apache/kafka/pull/22725#discussion_r3614481397
##########
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriverBuilder.java:
##########
@@ -19,20 +19,27 @@
import java.time.Instant;
import java.util.Objects;
import java.util.Optional;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.Objects;
import java.util.Properties;
/**
* Fluent builder for a {@link TopologyTestDriver}.
*
- * <p>This is the entry point for constructing a {@link TopologyTestDriver}.
- * Configure the builder and call {@link #build()}.
- * The {@link TopologyTestDriver} constructors remain functional but are
deprecated in favor of
- * this builder.</p>
+ * <p>This is the entry point for constructing a {@link TopologyTestDriver},
for both
+ * single and multi-partition mode. Declare the partition count of each
relevant topic, then
+ * call {@link #build()}: when at least one declared topic has more than one
partition the driver wires
+ * its multi-partition task graph; declaring only single-partition topics (or
none) keeps the legacy
+ * single-flat-task behaviour.
+ * The {@link TopologyTestDriver} constructors remain functional but are
+ * deprecated in favour of this builder.</p>
Review Comment:
done
##########
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriverBuilder.java:
##########
@@ -19,20 +19,27 @@
import java.time.Instant;
import java.util.Objects;
import java.util.Optional;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.Objects;
import java.util.Properties;
/**
* Fluent builder for a {@link TopologyTestDriver}.
*
- * <p>This is the entry point for constructing a {@link TopologyTestDriver}.
- * Configure the builder and call {@link #build()}.
- * The {@link TopologyTestDriver} constructors remain functional but are
deprecated in favor of
- * this builder.</p>
+ * <p>This is the entry point for constructing a {@link TopologyTestDriver},
for both
+ * single and multi-partition mode. Declare the partition count of each
relevant topic, then
+ * call {@link #build()}: when at least one declared topic has more than one
partition the driver wires
+ * its multi-partition task graph; declaring only single-partition topics (or
none) keeps the legacy
Review Comment:
removed 'legacy'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
