0xffff-zhiyan commented on code in PR #22805:
URL: https://github.com/apache/kafka/pull/22805#discussion_r3618117901
##########
raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotReader.java:
##########
@@ -110,15 +110,22 @@ public void close() {
public static <T> RecordsSnapshotReader<T> of(
RawSnapshotReader snapshot,
- RecordSerde<T> serde,
+ RecordsDecodingStrategy<T> decodingStrategy,
Review Comment:
Two versions works and is what I had in mind, see my previous
reply:https://github.com/apache/kafka/pull/22805#discussion_r3618055242. But I
don't think we can make one of them private because some caller outside
`org.apache.kafka.snapshot` like `KafkaRaftClient` and
`KRaftControlRecordStateMachine` can't use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
