chia7712 commented on code in PR #22326:
URL: https://github.com/apache/kafka/pull/22326#discussion_r3618423430
##########
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##########
@@ -167,6 +179,30 @@ KafkaProducer<byte[], byte[]>
createKafkaProducer(Properties props) {
Stats stats;
Stats steadyStateStats;
+ static byte[][] preAllocateKeys(Integer keyRange) {
Review Comment:
The KIP states that a large key range is expected, and the value payload is
already generated dynamically. I think we need to trust the JVM GC; otherwise,
it will cause an OOM error if users set a large range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
