mjsax commented on code in PR #22725:
URL: https://github.com/apache/kafka/pull/22725#discussion_r3618628118
##########
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java:
##########
@@ -558,7 +585,13 @@ private void pipeRecord(final String topicName,
final long timestamp,
final byte[] key,
final byte[] value,
- final Headers headers) {
+ final Headers headers,
+ final int explicitPartition) {
+ if (multiPartitionModeActive) {
+ runtime.pipeRecord(topicName, timestamp, key, value, headers,
explicitPartition);
Review Comment:
Depends on what is more logical? -- My gut feel would be, to first do a
refactoring and extract the existing logic into the corresponding interfaces
and implementation, and add multi-partition runtime later. But from a feature
freeze timeline POV, it might cut it short...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
