dino2895 commented on code in PR #22854:
URL: https://github.com/apache/kafka/pull/22854#discussion_r3618810302
##########
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java:
##########
@@ -216,7 +216,7 @@ public class RemoteLogManagerTest {
private UnifiedLog mockLog = mock(UnifiedLog.class);
private final MockScheduler scheduler = new MockScheduler(time);
- private final Properties brokerConfig =
kafka.utils.TestUtils.createDummyBrokerConfig();
+ private final Properties remoteLogManagerProps = new Properties();
Review Comment:
Thanks for the clarification and the example patch. I understand your point
now. I removed `remoteLogManagerProps` and updated `appendRLMConfig` to supply
the default values while preserving any test-specific settings already present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
