[
https://issues.apache.org/jira/browse/KAFKA-20828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18098245#comment-18098245
]
Jun Rao commented on KAFKA-20828:
---------------------------------
The simplest approach is to fix the shouldClientThrottle() method in those
responses. However, people may forget doing that for future requests.
For all new requests, if the response contains the throttleTimeMs field,
shouldClientThrottle() should be true. Another approach is to add this logic in
AbstractResponse.shouldClientThrottle() and remove the unnecessary override in
the subclasses. This way, we don't need to manually customize this method for
future new requests.
> shouldClientThrottle() implemented incorrectly for some requests
> ----------------------------------------------------------------
>
> Key: KAFKA-20828
> URL: https://issues.apache.org/jira/browse/KAFKA-20828
> Project: Kafka
> Issue Type: Bug
> Components: clients
> Reporter: Jun Rao
> Priority: Major
>
> AbstractResponse.shouldClientThrottle() defaults to false. The following 3
> responses have the throttleTimeMs field, but didn't override it to true.
> ConsumerGroupHeartbeatResponse, ShareGroupHeartbeatResponse,
> ShareGroupHeartbeatResponse
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
